Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform Button Styling #74

Closed
wants to merge 1 commit into from
Closed

Conversation

attorri
Copy link
Contributor

@attorri attorri commented Jan 7, 2025

There's no staging branch.

PO Approved -
OpenACR Editor - Responsive Views - Help Improve this page section - External link icon issue
[L2]OpenACR Editor - Responsive Views - Help Improve this page section - External link icon issue.
This is an existing issue in production as well and comes from original implementation.

Demo Link - https://gsa.github.io/openacr-editor-stage/

The "Help improve this page" section displays the "Email", "Fork & Edit on Github", and "New Github Issue" buttons. An external ink icon is displayed against all of these three buttons.

In responsive view, the external link icon size is not consistent and gets smaller or bigger based on the size of the button text. All the icons should be in the same size.

Please refer to the attached screenshot.
Ref https://cm-jira.usa.gov/browse/OGPWEB-12023

@attorri attorri marked this pull request as draft January 7, 2025 16:57
@attorri attorri marked this pull request as ready for review January 7, 2025 17:09
@attorri attorri closed this Jan 7, 2025
@attorri attorri reopened this Jan 7, 2025
@attorri attorri requested review from km719 and arnayv-47 January 10, 2025 20:49
@attorri attorri self-assigned this Jan 10, 2025
@attorri attorri closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant