Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test data optimization ADR #700

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Test data optimization ADR #700

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8a89ee
Introduce test data optimization ADR
Gabeblis Sep 18, 2024
fe1ae45
Correction: only scaffold invalid test data file
Gabeblis Sep 18, 2024
2f2c6c2
Provide more detail in ADR
Gabeblis Sep 19, 2024
4a61e0e
Date correction
Gabeblis Sep 19, 2024
8272d74
Add solution & consequences
Gabeblis Sep 20, 2024
958ca31
Add reference to #710.
aj-stein-gsa Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions documents/adr/0006-test-data-optimization-ADR.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# 6. Test data optimization ADR
Date: 2024-09/18

## Status
Proposed

## Context
Currently, all tests for constraints used by the constraint validation tool rely on the same 'ssp-all-INVALID.xml' test data file. This results in conflicts between many constraints, preventing the tests from failing properly when using shared test data files.
aj-stein-gsa marked this conversation as resolved.
Show resolved Hide resolved

## Possible Solutions
Gabeblis marked this conversation as resolved.
Show resolved Hide resolved
1. When the YAML tests are scaffolded for a constraint by running 'npm run constraint', the corresponding 'invalid' test data file specific to that constraint should also be scaffolded with the minimum necessary content.

aj-stein-gsa marked this conversation as resolved.
Show resolved Hide resolved
## Decision
No decision has currently been made.

## Consequences
Solution 1:
- Longer test run time.
Gabeblis marked this conversation as resolved.
Show resolved Hide resolved
Loading