Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Image upload “content-uploads-_inbox-warning-banner-jpg” #7942

Conversation

nick-mon1
Copy link
Contributor

@nick-mon1 nick-mon1 commented Sep 13, 2024

Adding new image to replace hard coded content

Preview

Testing:

  • visit preview and verify that the GSA wanner banner is present and check that with a reduced screen size the image does not break or mess with any wrapping issues

Copy link

🔍 Preview in Federalist

Copy link
Contributor

@bonnieAcameron bonnieAcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the image needs alt-text. Suggested some for you to review/commit.

data/images/warning-banner.yml Outdated Show resolved Hide resolved
RileySeaburg and others added 2 commits September 17, 2024 05:28
Add suggested changes from Bonnie

Co-authored-by: Bonnie Cameron <[email protected]>
@clmedders
Copy link
Contributor

@bonnieAcameron thank you for adding that!

@RileySeaburg this is ready for a final review and merge

Copy link
Member

@RileySeaburg RileySeaburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, merging because the suggested changes have been addressed.

@RileySeaburg
Copy link
Member

I can't merge actually until you approve @bonnieAcameron

@nick-mon1 nick-mon1 closed this Oct 4, 2024
@nick-mon1 nick-mon1 deleted the cms/image-upload/content-uploads-_inbox-warning-banner-jpg branch October 4, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants