-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce responsive image variants #7908
Conversation
@nick-mon1 did you test upload with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only get one file, and the file is blank.
Thought@RileySeaburg This is probably not be related to these code changes for displaying and generating the same image types. Still need to address async issues with gulp file upload scripts. |
@nick-mon1 I would agree completely if the image upload didn't already work. But I do agree this is an async issue. |
Summary
Updates code to only generate and serve
mobile (800)
anddesktop (1200)
responsive sizes.Preview
Note
For some pages, there is only one variant, see below
Solution
Simplified responsive variants from 4 to 2 sizes. Serving one size for mobile and desktop will not impact performance and quality.
What you should see in network panel
Updates the
file-process.js
to generate the above two sizes.Updates
img.html
partial/short code to display above two sizes.Other variant sizes will be served if the
800
or1200
is not present.How To Test
800
or1200
size, other image size is served