Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fellow and project page links on home page #462

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

jaredbain
Copy link
Contributor

@jaredbain jaredbain commented Apr 12, 2024

Fixes #450

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have performed a self-review of my own code and have no open issues
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings or syntax errors
  • I have verified Draft on actual mobile devices, especially Safari-based

@jaredbain jaredbain marked this pull request as ready for review April 19, 2024 18:25
@jaredbain jaredbain requested a review from chriskuang4 April 19, 2024 18:25
@chriskuang4
Copy link
Contributor

Rewording based on what I put in chat, then I will review and approve.
Also will create a separate ticket to find four vertical images to show on mobile (landscape photos getting cropped oddly).

@jaredbain
Copy link
Contributor Author

@chriskuang4 Ready for approval

Copy link
Contributor

@chriskuang4 chriskuang4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, adding a separate issue to fix the cropping of images on mobile to have vertical images instead.

@chriskuang4
Copy link
Contributor

Approved, and opened #465 as we discussed for the mobile images, etc.

@jaredbain jaredbain merged commit f8e8e94 into main Apr 26, 2024
5 checks passed
@jaredbain jaredbain deleted the home_page_link_updates branch April 26, 2024 14:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home page updates
2 participants