Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulnerability and accessibility update #2094

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Vulnerability and accessibility update #2094

merged 8 commits into from
Dec 4, 2024

Conversation

jairoanaya
Copy link
Contributor

This PR includes changes to resolve vulnerabilities related to SRI and accessibility issues found by Pages.gov.

Details:

  • Elements must meet minimum color contrast ratio thresholds.
  • ul and ol must only directly contain li, script or template elements.
  • Frames must have an accessible name.
  • Links must have discernible text.
  • Adding SRI to JS and CSS.
  • Removing unix timespan on images.

jairoanaya and others added 8 commits November 22, 2024 16:07
@jairoanaya jairoanaya added this to the Sprint 12/17/24 milestone Dec 4, 2024
@jairoanaya jairoanaya requested a review from kkrug December 4, 2024 21:08
@jairoanaya jairoanaya self-assigned this Dec 4, 2024
@kkrug kkrug merged commit a54f733 into production Dec 4, 2024
7 checks passed
This was linked to issues Dec 4, 2024
Pages Accessibility Report Fixes - 2536 #2065
Closed
Pages Vulnerability Report Fixes - 2537 #2064
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrug kkrug kkrug approved these changes

Assignees

@jairoanaya jairoanaya

Labels
None yet
Projects
None yet
Milestone
Sprint 12/31/24
Development

Successfully merging this pull request may close these issues.

Pages Accessibility Report Fixes - 2536 Pages Vulnerability Report Fixes - 2537
4 participants
@jairoanaya @kkrug @r-bartlett-gsa @jdonis