Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ckan.ini #1417

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Update ckan.ini #1417

merged 4 commits into from
Jul 31, 2024

Conversation

jbrown-xentity
Copy link
Contributor

Add necessary config items from ckan2.10 changelog: https://docs.ckan.org/en/2.10/changelog.html#migration-notes-2-10

Related to GSA/data.gov#2138

Add necessary config items from ckan2.10 changelog: https://docs.ckan.org/en/2.10/changelog.html#migration-notes-2-10
@btylerburton
Copy link
Contributor

Do you think we need this signing key, too?

beaker.session.validate_key = CHANGE_ME

@btylerburton
Copy link
Contributor

Same failing test. I'm not sure if anyone has tried running this locally to repro the results.

@rshewitt
Copy link
Contributor

Same failing test. I'm not sure if anyone has tried running this locally to repro the results.

i'll look further into this

@rshewitt
Copy link
Contributor

for some reason cypress isn't able to find the feedback modal where class=fba-modal-dialog. @btylerburton do you see an issue with the new element being selected? I'm concerned about, what looks like, a generated id appended to the end of the touchpoint class name ( i.e. #touchpoints-form-fd986495 ) and whether this is a viable name to use

@btylerburton
Copy link
Contributor

I think fd986495 is touchpoints id for our form so it probably wouldn't change. That said, we can look for the modal by class instead of id and the test will be a little less brittle.

@jbrown-xentity
Copy link
Contributor Author

@GSA/data-gov-dev-team if someone could approve this, we could get this rolled out asap... And thanks for the test fixes @btylerburton and @rshewitt !

@jbrown-xentity jbrown-xentity merged commit d536444 into main Jul 31, 2024
9 checks passed
@jbrown-xentity jbrown-xentity deleted the feature/secure-cookie branch July 31, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants