Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circleci project setup #88

Merged
merged 41 commits into from
Jan 14, 2025
Merged

Circleci project setup #88

merged 41 commits into from
Jan 14, 2025

Conversation

jadudm
Copy link
Contributor

@jadudm jadudm commented Jan 14, 2025

We prefer smaller PRs that merge more often.

Haiku-length summary

What is code signing
Forget it once and you know
Never to forget

Additional details

For reasons that are unclear, this PR is essentially the same as... no. No it isn't.

So, commit db97d99 is unsigned. This attempted to sign and rebase the commit by:

git rebase -i 1742c0b53f9df227ada5ce3b48b56e1448cbb546
git commit --amend --no-edit -S
git rebase --continue

which has signed the commit, but it still leaves the original unsigned. The question is whether or not GH will see this as "ok," or if it will reject this PR as well as containing an unsigned commit.

The PR containing an unsigned commit in a branch is:

#81

PR Checklist: Submitter

  • Link to an issue if possible. If there’s no issue, describe what your branch does. Even if there is an issue, a brief description in the PR is still useful.
  • List any special steps reviewers have to follow to test the PR. For example, adding a local environment variable, creating a local test file, etc.
  • For extra credit, submit a screen recording like this one.
  • Make sure you’ve merged main into your branch shortly before creating the PR. (You should also be merging main into your branch regularly during development.)
  • Make sure that whatever feature you’re adding has tests that cover the feature. This includes test coverage to make sure that the previous workflow still works, if applicable.
  • Make sure the E2E tests pass.
  • Do manual testing locally.
    • If that’s not applicable for some reason, check this box.
  • Once a PR is merged, keep an eye on it until it’s deployed to dev, and do enough testing on dev to verify that it deployed successfully, the feature works as expected, and the happy path for the broad feature area still works.

PR Checklist: Reviewer

  • Pull the branch to your local environment and run make macup ; make e2e" (FIXME)
  • Manually test out the changes locally
    • Check this box if not applicable in this case.
  • Check that the PR has appropriate tests.

The larger the PR, the stricter we should be about these points.

jadudm added 30 commits January 9, 2025 09:24
These are not nice in CircleCi/YAML.
Should be faster
Although this would be nice as a separate commit, I'm working to get the
automated builds going. It ended up in this branch.

This added `if err != nil` in many places.
This moves linting into the container in the makefile.

Also, more code with linting issues that I forgot to commit.

Want to see this work in Circle/CI.
Should we use *all* of the lints?

Either way, lots of formatting.
This gets us to litner zero.
jadudm added 11 commits January 13, 2025 20:17
I lied. Forgot a directory.
Errors on indenting don't make it back to the VSCode client.
Feel like there must be a better way.

Even with the fixes, the linter is angry.

This does address CodeQL, however.
Dependabot is angry.
@IsabelLaurenceau IsabelLaurenceau self-requested a review January 14, 2025 14:06
@IsabelLaurenceau
Copy link
Contributor

Turning off requirements for unsigned commits as circleci's original commit was unsigned. Rebased to create a sign commit, but still blocked. Will turn on requirement again after merge.

@jadudm jadudm added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit d23d5e8 Jan 14, 2025
3 checks passed
@IsabelLaurenceau
Copy link
Contributor

Requirement for signed commits has been added back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants