-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circleci project setup #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not nice in CircleCi/YAML.
Should be faster
Although this would be nice as a separate commit, I'm working to get the automated builds going. It ended up in this branch. This added `if err != nil` in many places.
This moves linting into the container in the makefile. Also, more code with linting issues that I forgot to commit. Want to see this work in Circle/CI.
Should we use *all* of the lints? Either way, lots of formatting.
Feel like there must be a better way. Even with the fixes, the linter is angry. This does address CodeQL, however.
Dependabot is angry.
IsabelLaurenceau
approved these changes
Jan 14, 2025
Turning off requirements for unsigned commits as circleci's original commit was unsigned. Rebased to create a sign commit, but still blocked. Will turn on requirement again after merge. |
Requirement for signed commits has been added back. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer smaller PRs that merge more often.
Haiku-length summary
What is code signing
Forget it once and you know
Never to forget
Additional details
For reasons that are unclear, this PR is essentially the same as... no. No it isn't.
So, commit db97d99 is unsigned. This attempted to sign and rebase the commit by:
which has signed the commit, but it still leaves the original unsigned. The question is whether or not GH will see this as "ok," or if it will reject this PR as well as containing an unsigned commit.
The PR containing an unsigned commit in a branch is:
#81
PR Checklist: Submitter
main
into your branch shortly before creating the PR. (You should also be mergingmain
into your branch regularly during development.)PR Checklist: Reviewer
make macup ; make e2e"
(FIXME)The larger the PR, the stricter we should be about these points.