-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FederalProgramNames.json #4650
base: main
Are you sure you want to change the base?
Update FederalProgramNames.json #4650
Conversation
Terraform plan for meta No changes. Your infrastructure matches the configuration.
📝 Plan generated in Pull Request Checks #4266 |
Terraform plan for dev Plan: 1 to add, 0 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "*******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2025-01-24T18:53:11Z" -> (known after apply)
}
}
Plan: 1 to add, 0 to change, 1 to destroy. 📝 Plan generated in Pull Request Checks #4266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github will not display the diffs since they are so big (and my browser hangs if click "load diff")
I checked out the branch locally, and opened both files in my IDE. The IDE said both are valid json/csv files. (No syntax errors).
I am trusting the actual data is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @LynnMHouston! Added some suggestions inline.
Co-authored-by: Dan Swick <[email protected]>
Co-authored-by: Dan Swick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. @LynnMHouston and I downloaded the newly-generated awards workbook and spot-checked for some of the new inactive ALNs. We also tested one to make sure it showed up in the program name dropdown.
edit: actually, looks like one of the tests is failing now, so this needs more attention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like tests are failing
Makefile will now merge the 2 CSV and update FederalProgramNames.json
backend/schemas/README.md
Outdated
3. Under "key word" search, choose simple and "any words" and then "active" listings. | ||
4. Click "Actions" on the upper-right and then "download" to get the CSV file of active listings. Save this as `/schemas/source/data/alns_to_be_merged/active-alns.csv`. | ||
5. Repeat the process, choosing "inactive" listings to get the CSV file for inactive ALN listings. Save this as `/schemas/source/data/alns_to_be_merged/inactive-alns.csv`. These have to be done separately due to a limit on the amount of records that can be downloaded into a CSV file. | ||
7. Finally, run `make all`. This will merge the CSVs and generate the lookup schemas and the Excel templates. To verify that the "make all" command has run correctly, check to see that the`backend/schemas/source/base/FederalProgramNames.json` file has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you need to activate your vitrual env inside backend/schemas/
before running make all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! Added it to the ReadMe. Thank you!
This is what's causing the failure in your PR. This line was manually updated. You want to look for the same line in the author section files and update them accordingly. |
…FederalProgramNames.json-with-inactive-listings
…FederalProgramNames.json-with-inactive-listings
|
Leigh asked us to update this file with inactive ALN listings in advance of her meeting with OMB tomorrow 1/23/2025. I got the info from a download of SAM.gov's search interface for ALN listings, as discussed here
#4545
In this PR:
merge_aln_csvs.py
.Testing:
PR Checklist: Submitter
main
into your branch shortly before creating the PR. (You should also be mergingmain
into your branch regularly during development.)git status | grep migrations
. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrations
to reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR Checklist: Reviewer
make docker-clean; make docker-first-run && docker compose up
; then rundocker compose exec web /bin/bash -c "python manage.py test"
The larger the PR, the stricter we should be about these points.
Pre Merge Checklist: Merger
-/+ resource "null_resource" "cors_header"
should be destroying and recreating its self and~ resource "cloudfoundry_app" "clamav_api"
might be updating itssha256
for thefac-file-scanner
andfac-av-${ENV}
by default.main
.