Creating validation waiver tables #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Terraform plan for meta No changes. Your infrastructure matches the configuration.✅ Plan applied in Deploy to Development and Management Environment #726 |
|
Terraform plan for dev No changes. Your infrastructure matches the configuration.✅ Plan applied in Deploy to Development and Management Environment #726 |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 87ac9d8 |
sambodeme
reviewed
Jun 27, 2024
backend/dissemination/models.py
Outdated
|
|
||
|
|
||
| class WaiverType(models.TextChoices): | ||
| auditee_certifying_official = ( |
There was a problem hiding this comment.
Suggested change
| auditee_certifying_official = ( | |
| AUDITEE_CERTIFYING_OFFICIAL = ( |
sambodeme
reviewed
Jun 27, 2024
backend/dissemination/models.py
Outdated
| "auditee_certifying_official", | ||
| "No auditee certifying official is available", | ||
| ) | ||
| auditor_certifying_official = ( |
There was a problem hiding this comment.
Suggested change
| auditor_certifying_official = ( | |
| AUDITOR_CERTIFYING_OFFICIAL = ( |
sambodeme
reviewed
Jun 27, 2024
| "No auditor certifying official is available", | ||
| ) | ||
| active_uei = ( | ||
| "active_uei", |
There was a problem hiding this comment.
Suggested change
| "active_uei", | |
| "ACTIVE_UEI", |
sambodeme
reviewed
Jun 27, 2024
backend/dissemination/models.py
Outdated
| justification = models.TextField( | ||
| "Brief plain-text justification for the waiver", | ||
| ) | ||
| waiver_type = models.TextField( |
There was a problem hiding this comment.
Suggested change
| waiver_type = models.TextField( | |
| waiver_type = models.CharField( |
sambodeme
reviewed
Jun 27, 2024
| "Brief plain-text justification for the waiver", | ||
| ) | ||
| waiver_type = models.TextField( | ||
| "The waiver type", |
There was a problem hiding this comment.
Suggested change
| "The waiver type", | |
| "The waiver type", | |
| max_length=100, |
sambodeme
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4024
In this PR:
SacValidationWaiver,UeiValidationWaiver, andWaiverType(used forSacValidationWaiver.waiver_typechoices)Testing:
PR checklist: submitters
maininto your branch shortly before creating the PR. (You should also be mergingmaininto your branch regularly during development.)git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrationsto reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up; then rundocker compose exec web /bin/bash -c "python manage.py test"The larger the PR, the stricter we should be about these points.