2024-06-05 | MAIN --> PROD | DEV (b25ed53) --> STAGING #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added InvalidAuditRecord and IssueDescriptionRecord django models * Added InvalidAuditRecord and IssueDescriptionRecord django models * Updated IssueDescriptionRecord per ADR change * Updated IssueDescriptionRecord per ADR change
* Disable the schedule for daily staging deploy * Change the comments so the file isn't invalid * Disable deploy to production
* Updating handling of empty passthrough awards * Removing _v2 * Fixing tests * Lint * Updating validation * Fixing check_gsa
* fix type requirement copy * fix comment
* Processing blank policies and rate note contents before usage * Update * Linting * Update * Transformations * Test cases for Transformations * Added accounting_policies * Linting * Linting * Add rate_explained Co-authored-by: Hassan D. M. Sambo <[email protected]> --------- Co-authored-by: Hassan D. M. Sambo <[email protected]>
* A11y - Install Cypress Axe, new test file * A11y - Allow SAC/home access if DISABLE_AUTH =true * A11y - load_fixtures for new SACs, dummy dissem * Linting, remove unused file. * A11y - HTML and SCSS changes for accessibility * A11y - Docs update for new workflow * Add accessibility tests to testing-from-ghcr.yml * Cypress - Update report upload page input ids * Lint - Unused imports * Lint - Various black changes, not a11y related * Lint - Reformat new cypress files * Re-linting - Whoops, wrong version of black * GHA - upload screenshots, use dc-web, spaces * Testing with just a11y workflow * Testing with a historical data load * Try changing the operating user for permissions * A hail mary of sorts - user 1001 in docker compose * ... Try user root on the a11y tests * ... Try non-root user with specific cypress image * Remove the user switch. * Once more: non-root user, node 18 cypress image * Attempt a11y tests in GHCR with node 20 * Try root user on a11y runner * Revert testing-from-gchr.yml changes * Add `npm i` to testing doc. * Strike "TESTING" from e2e TSTDAT generator command * Remove references to pa11y * Remove references to lighthouse * Include an a11y command in package.json * Remove a11y reference from staging deploy yml
* add cross val for no fed awards * add new test to bandit exclude dirs
* #3696 Code improvement * #3696 More code improvement * #3696 Updated logic to ignore historical audit report with duplicate reference number * #3696 Allowed cross validation functions to access dat source * Update logic to track and record invalid report records * #3696 Django migration * #3696 Added test case * #3696 Fixed failing tests
* Removed hist_models * Using dissemination models * Using dissemination models * Using dissemination models * Removed hist_models * Removed hist_models * Removed hist_models * Using dissemination models * Removed hist_models * Using dissemination models * Using dissemination models * Using dissemination models * Using dissemination models * Format with Black * Format with Black * Tested cog/over test cases * Renamed get_dbkey to get_reportid_dbkey * Tested cog_over * Tested test cases * Tested test cases * Tested test cases * Tested test cases * Tested test cases * Tested test cases * run2022_23 command details * Pass year as parameter * Renamed run_2022.py to run_2022_23.py * Merged with main and update migrations * Merged with main and update migrations * Update * Allowing 2022 through 2024 * Reformat * Update * Renamed run_2022_23.py to check_cog_over_for_year.py * Renamed run_2022_23.py to check_cog_over_for_year.py * Updates to descriptions * Updates to descriptions * Updates to descriptions * Updates to descriptions * Updates to descriptions * Updates to descriptions * Merged with main and updated migrations * Merged with main and updated migrations
* #3696 Code improvement * #3696 More code improvement * #3696 Updated logic to ignore historical audit report with duplicate reference number * #3696 Allowed cross validation functions to access dat source * Update logic to track and record invalid report records * #3696 Django migration * #3696 Added test case * Added EXTRA_FINDING_REFERENCE_NUMBERS_IN_CAPTEXT * Handle invalid audit record * Handle invalid audit record * Handle invalid audit record * Create invalid audit record when captext findingrefnums is not present in findings * Create invalid audit record when captext findingrefnums is not present in findings * Testing * Testing * Testing * Testing * Tested * Tested * Merged with origin/3696-address-historical-awards-with-repeated-references * Fixed merge issues * Fixed merge issues * Fixed merge issues, linting * Fixed merge issues, linting * Fixed merge issues, linting * Rename test * Rename test * Fixed merge issue * Linting * Update * Update * Update * Update * Update * Update * Update --------- Co-authored-by: Hassan D. M. Sambo <[email protected]>
* Search - add search timing to results count * Remove gitignore lighthouseci * Remove a redundant line * Add time display to advanced search, and _lint_ * Test updates to cover the new results format
* Creating xform_missing_cluster_total_v2 * Using xform_missing_cluster_total_v2 in tests * Adding unit test * Lint * Lint * Lint * Fixing run_all_checks * Simplifying checks_with_special_args * Tracking for all invalid totals * Lint * Lint * Removing is_data_migration for total cluster check * Lint * Lint * Lint * Invalid tracking fix * Fixing unit test * Lint
* Handle extra findings text references * Handle extra findings text references * Handle extra findings text references * Handle extra findings text references * Handle extra findings text references * Resolved merge conflict
* Search - `distinct` call compatible with cog/over * Search tests: Add a basic sort test for cog/over * Cog/over test - put initial data very out of order * Cog/over sort - alphabetical with column values
* add search test data+pageobjects * modified search-tests.cy.js + searchPage.js * add plugin downloadfile to devDependencies+addCommands.js require cypress-dpwnloadfile+addSumReport to searchPage.js+methods+searchTests * remove search-audit-reports.cy.js + add modified search-tests.cy.js + modified searchPage.js * Comment out adv search + singleAuditBtn + SumReportDownload * Gen-Info POM changes * Gen-Info POM changes * modified general-info.js + modified genInfoData json files to be just one file with all data * fix format on general-info.js * update cypress version * update package-lock.json * rename files * merged main into branch & changed uswds to 3.7.0 * merged main into branch & changed uswds to 3.7.0 * modified search-tests.cy.js,login-go.js,initialize-audit.js,search-page.js,gen-info.js,added new file search_data.json & deleted individual search page data json files * Oops - Duplicate package entries * rename search it blocks, remove empty spaces & add semicolons to files in cypress test suite * refactor search-tests.cy.js & search-page.js & restore support files * Remove comments/ old code from search-tests.cy.js * Remove old functions from search-page.js * change import from generalinfoform to testvalidgeneralinfo in create-new-audit.cy.js * add reset button function, element and test and rearrange search tests * fix spacing in search-tests.cy.js * update npm * revert a11y test ID changes --------- Co-authored-by: Purvin <[email protected]> Co-authored-by: James Person <[email protected]> Co-authored-by: Daniel Swick <[email protected]>
* Handling non-USA audits * Cleaning up zip handling * Fixing unit tests * Adding country test * Non-US check tweak * Fixing unit tests
* Undo the workflow changes * verbiage fix * remove dispatch entirely
Use the autogenerated tag for bpmn render PRs to clean up seldom-used labels.
jadudm
added
autogenerated
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Bug: "Test Site" Banner on Production Error Pages (#3573) * Add error handlers for other standard error pages * Add error handlers for other standard error pages * Reset file upload timeout to 30s. Oops. * back to 8 (#3579) --------- Co-authored-by: James Person <[email protected]>
[hotfix] Merge main --> prod (#3580)
|
Terraform plan for staging Plan: 0 to add, 2 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# module.staging.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
!~ resource "cloudfoundry_app" "clamav_api" {
!~ docker_image = "ghcr.io/gsa-tts/fac/clamav@sha256:a6b645538b565528a5dba563be597d5d7c8fe162a4924b14048d50d117450cf8" -> "ghcr.io/gsa-tts/fac/clamav@sha256:189736dbbb892c4bd7e7337b3850b767f05136b583e5e9574b74cc8f7a2b6731"
id = "d1bea029-d2d3-4b68-b16d-b216bcaea573"
name = "fac-av-staging"
# (17 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.staging.module.file_scanner_clamav.cloudfoundry_app.clamav_api will be updated in-place
!~ resource "cloudfoundry_app" "clamav_api" {
!~ docker_image = "ghcr.io/gsa-tts/fac/clamav@sha256:a6b645538b565528a5dba563be597d5d7c8fe162a4924b14048d50d117450cf8" -> "ghcr.io/gsa-tts/fac/clamav@sha256:189736dbbb892c4bd7e7337b3850b767f05136b583e5e9574b74cc8f7a2b6731"
id = "28008a8e-f85b-4320-aedf-8522a2371bec"
name = "fac-av-staging-fs"
# (17 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.
Warning: Argument is deprecated
with module.staging.module.cg-logshipper.module.s3-logshipper-storage.cloudfoundry_service_instance.bucket,
on /tmp/terraform-data-dir/modules/staging.cg-logshipper.s3-logshipper-storage/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 4 more similar warnings elsewhere)✅ Plan applied in Deploy to Staging Environment #218 |
|
Terraform plan for production Plan: 0 to add, 2 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# module.production.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
!~ resource "cloudfoundry_app" "clamav_api" {
!~ docker_image = "ghcr.io/gsa-tts/fac/clamav@sha256:a6b645538b565528a5dba563be597d5d7c8fe162a4924b14048d50d117450cf8" -> "ghcr.io/gsa-tts/fac/clamav@sha256:189736dbbb892c4bd7e7337b3850b767f05136b583e5e9574b74cc8f7a2b6731"
id = "5d0afa4f-527b-472a-8671-79a60335417f"
name = "fac-av-production"
# (17 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.production.module.file_scanner_clamav.cloudfoundry_app.clamav_api will be updated in-place
!~ resource "cloudfoundry_app" "clamav_api" {
!~ docker_image = "ghcr.io/gsa-tts/fac/clamav@sha256:a6b645538b565528a5dba563be597d5d7c8fe162a4924b14048d50d117450cf8" -> "ghcr.io/gsa-tts/fac/clamav@sha256:189736dbbb892c4bd7e7337b3850b767f05136b583e5e9574b74cc8f7a2b6731"
id = "a14bb29f-8276-4967-9754-cf9c4187ebe3"
name = "fac-av-production-fs"
# (17 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.
Warning: Argument is deprecated
with module.domain.cloudfoundry_service_instance.external_domain_instance,
on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
45: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 5 more similar warnings elsewhere)📝 Plan generated in Pull Request Checks #3148 |
tadhg-ohiggins
approved these changes
Jun 5, 2024
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d07c579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an auto-generated pull request to merge main into prod for a staging release on 2024-06-05 with the last commit being merged as b25ed53