-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganise plotting module #133
base: master
Are you sure you want to change the base?
Conversation
Also break `gplately.plot` module up into several files (one for each class).
See the code below. The seg0 and seg1 could be Point in some situation and it will break linemerge([seg0, seg1]). Could you please also look into this? Lines 611 to 624 in 9a751e9
|
@cpalfonso - a gentle reminder for you to look into the issue raised by @michaelchin |
This happened to me in https://github.com/GPlates/gplately/blob/master/Notebooks/01-GettingStarted.ipynb in case you would like to reproduce the error. |
@cpalfonso - can you revisit this again, please? |
@cpalfonso if you would like to finish the subduction teeth improvement, it would be great if you could take care of #188 as well. Sabin reported this issue. You might need to contact him regarding how to reproduce the bug. Thanks. |
There are a few major changes in this pull request:
gplately.plot
by splitting the module up into several files since the single huge file was becoming unwieldygplately.plot.SubductionTeeth
class