Skip to content

Commit

Permalink
add some instructions for Bianca
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelchin committed Dec 6, 2024
1 parent 2d7561e commit 0a72e3f
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions gplately/utils/convert_geometries.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,20 @@ def convert_polygons_to_polylines(feature_collection: pygplates.FeatureCollectio
"""similar to the function above"""
# TODO:
# get the exterior ring of the polygon and convert it to polyline?
# Bianca, let's try to do this function
# step 1: create a new function "convert_polygons_to_polylines_within_feature"
# the new function should be very similar to "convert_polylines_to_polygons_within_feature"
# You may copy the code from "convert_polylines_to_polygons_within_feature" to the new function and make changes to the copy
# step 2: get the exterior ring and interior rings from the polygon and convert them to PolylineOnSphere
# John may have better ideas on this?
# see the links below for relavant pygplates doc
# https://www.gplates.org/docs/pygplates/generated/pygplates.polygononsphere#pygplates.PolygonOnSphere.get_exterior_ring_points
# https://www.gplates.org/docs/pygplates/generated/pygplates.polygononsphere#pygplates.PolygonOnSphere.get_interior_ring_points
# https://www.gplates.org/docs/pygplates/generated/pygplates.polylineonsphere#pygplates.PolylineOnSphere.__init__
# step 3: try to call this function in test_convert_geometries.py

#
# Please feel free to ask me or John if you got stuck at some point
# mostly, this is a training task. John and I are obliged to provide support.
#
pass

0 comments on commit 0a72e3f

Please sign in to comment.