Radix sort one-sweep #117
Draft
Radix sort one-sweep #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParallelPrimitives/RadixSort.cpp
Outdated
| } | ||
| } | ||
| int maxBlocksPerMP = 0; | ||
| oroError e = oroOccupancyMaxActiveBlocksPerMultiprocessor( &maxBlocksPerMP, oroFunctions[Kernel::SORT_GHISTOGRAM], GHISTOGRAM_THREADS_PER_BLOCK, 0 ); |
There was a problem hiding this comment.
I think I forgot to fix it to oroModuleOccupancyMaxActiveBlocksPerMultiprocessor
based on #96
There was a problem hiding this comment.
What is the fix? Just changing oroOccupancyMaxActiveBlocksPerMultiprocessor --> oroModuleOccupancyMaxActiveBlocksPerMultiprocessor?
There was a problem hiding this comment.
Yes. "module" is for driver api
There was a problem hiding this comment.
oroOccupancyMaxActiveBlocksPerMultiprocessor always fails
|
I checked behavior on RX 7900 XTX and RTX 4090 and worked well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting the code from the previous repo/PR: amdadvtech#87