GPII-3780: Solve "windows.desktopBackground" and ""windows.desktopBackgroundColor" transformations issues #754
Conversation
…com.microsoft.windows.desktopBackground' transformations
…s.desktopBackgroundColor' solutions
…lor' and 'windows.desktopBackground'
JavierJF
changed the title
|
CI job passed: https://ci.gpii.net/job/universal-tests/1620/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/1890/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/1892/ |
GPII-3780: Improve the tranformation for "ImageConfig" in win32.json5.
|
CI job passed: https://ci.gpii.net/job/universal-tests/1893/ |
testData/solutions/win32.json5
Outdated
| @@ -5102,9 +5103,23 @@ | |||
| }, | |||
| "capabilitiesTransformations": { | |||
| "SolidColorConfig": { | |||
| // This transform is necessary due to issue GPII-3784. | |||
There was a problem hiding this comment.
I think this transform is no longer required, right? See https://issues.gpii.net/browse/GPII-3784
There was a problem hiding this comment.
You were right, I have changed it and things are being tested in CI, I have also tested the Windows pull in local, and I will also re-trigger Windows CI once this is done.
|
Hey @JavierJF can you update this with current master? |
|
@javihernandez Done! |
|
CI job passed: https://ci.gpii.net/job/universal-tests/1903/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/1905/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/1924/ |
|
Mothballed until the upcoming work on the LSR is addressed. |
|
As discussed in the meeting, this and other pulls from JJ should be addressed once the initial work on the LSR is reviewed and approved. Yet again he is using an intra-application transform (implied setting) here, I'd rather bring this onboard once we have a better mechanism for that. |
No description provided.