NetScaler Terraform code Rework

[LooseDevGoose]

Rework / Removals:
-Remove remote modules, make modules local
-Rework module structure
# contains all netscaler vsphere deployment code
-vpshere.netscaler.deployment

# contains all base configuration / best practice values / vservers / gateway etc
-netscaler.base.configuration

# Contains all letsencrypt related setup (including vservers)
netscaler.letsencrypt

-Reworked variable structure / names
-Removed string concatenation on complex variables
-Removed wait timers
-Removed time module
-Squashed endpoint resources
-Renamed all variables to match the other Terraform deployments

Fixes:
-Fixed reapply errors regarding the default timezone
-Fixed reapply errors when (re)defining an SSL profile

Additions:

-Included type checking on all (NetScaler related) variables. Security is all the rage.

-Incorperate object instead of maps for improved data structure.

-Included best practice of using tfvars file. Added a fully populated one for example config.

-Included license logic: you can also deploy a non-licensed (/freemium) netscaler now, and the configuration logic will adapt.

-Traveled the seven seas of NetScaler API documentation and optimized code logic flow (with appropiate pirate drinks).

-AAA vServer added

-Advanced authentication added

-Gateway now authenticates via auth profile with the AAA vserver

-Firmware versions 13.1 & 14.1 now supported.

-Virtual Servers / Services / and server objects no longer created through abstract looping; new structure with object mapping improves readability, scaling and debugging capability.. and other buzzwords the marketing people love.

Configuration changes:

-Enabled HTTP/2 on HTTP Profile
-Enabled Strong Password enforcement

[github-actions]

Test Results

  2 files  ±0   2 suites   - 1   0s ⏱️ ±0s
106 tests +3  42 ✅ +7  0 💤 ±0  64 ❌  - 4 
129 runs  +1  42 ✅ +7  0 💤 ±0  87 ❌  - 6 

For more details on these failures, see this check.

Results for commit a4049b9. ± Comparison against base commit c537b0f.

This pull request removes 16 and adds 19 tests. Note that renamed tests count towards both.

/citrix-adc/main.tf.adc-01-build ‑ [NONE][CKV_TF_1] Ensure Terraform module sources use a commit hash
/citrix-adc/main.tf.adc-02-reset-password ‑ [NONE][CKV_TF_1] Ensure Terraform module sources use a commit hash
/citrix-adc/main.tf.adc-03-license ‑ [NONE][CKV_TF_1] Ensure Terraform module sources use a commit hash
/citrix-adc/main.tf.adc-04-base ‑ [NONE][CKV_TF_1] Ensure Terraform module sources use a commit hash
/citrix-adc/main.tf.adc-05-ssl ‑ [NONE][CKV_TF_1] Ensure Terraform module sources use a commit hash
/citrix-adc/main.tf.adc-06-letsencrypt-lb ‑ [NONE][CKV_TF_1] Ensure Terraform module sources use a commit hash
/citrix-adc/main.tf.adc-07-letsencrypt ‑ [NONE][CKV_TF_1] Ensure Terraform module sources use a commit hash
/citrix-adc/main.tf.adc-09-lb ‑ [NONE][CKV_TF_1] Ensure Terraform module sources use a commit hash
/citrix-adc/main.tf.adc-10-gateway ‑ [NONE][CKV_TF_1] Ensure Terraform module sources use a commit hash
/citrix-adc/main.tf.adc-11-cs ‑ [NONE][CKV_TF_1] Ensure Terraform module sources use a commit hash
…

/azure/containers.tf.azurerm_container_group.docker ‑ [NONE][CKV_AZURE_235] Ensure that Azure container environment variables are configured with secure values only
/azure/delivery/avd/network_interfaces.tf.module.AVD.azurerm_network_interface.AzureNic[0] ‑ [NONE][CKV2_AZURE_39] Ensure Azure VM is not configured with public IP and serial console access
/azure/delivery/avd/network_interfaces.tf.module.AVD.azurerm_network_interface.AzureNic[1] ‑ [NONE][CKV2_AZURE_39] Ensure Azure VM is not configured with public IP and serial console access
/azure/modules/azure.mp.vm.windows/network_interfaces.tf.module.ActiveDirectory.azurerm_network_interface.AzureNic[0] ‑ [NONE][CKV2_AZURE_39] Ensure Azure VM is not configured with public IP and serial console access
/azure/modules/azure.mp.vm.windows/network_interfaces.tf.module.CVADs.module.cloudconnectors.azurerm_network_interface.AzureNic[0] ‑ [NONE][CKV2_AZURE_39] Ensure Azure VM is not configured with public IP and serial console access
/azure/modules/azure.mp.vm.windows/network_interfaces.tf.module.CVADs.module.cloudconnectors.azurerm_network_interface.AzureNic[1] ‑ [NONE][CKV2_AZURE_39] Ensure Azure VM is not configured with public IP and serial console access
/azure/modules/azure.mp.vm.windows/network_interfaces.tf.module.ManagementServer.azurerm_network_interface.AzureNic[0] ‑ [NONE][CKV2_AZURE_39] Ensure Azure VM is not configured with public IP and serial console access
/azure/sql.tf.azurerm_mssql_database.loadgen ‑ [NONE][CKV_AZURE_224] Ensure that the Ledger feature is enabled on database that requires cryptographic proof and nonrepudiation of data integrity
/azure/sql.tf.azurerm_mssql_database.loadgen ‑ [NONE][CKV_AZURE_229] Ensure the Azure SQL Database Namespace is zone redundant
/azure/sql.tf.azurerm_mssql_server.sql ‑ [NONE][CKV2_AZURE_45] Ensure Microsoft SQL server is configured with private endpoint
…