Fix data race in vtty_delete.

vtty_list is a linked list protected by a mutex. vtty->pprev is part of the linked list and was being accessed without aquiring the lock.
GNS3 · Mar 24, 2024 · bf37219 · bf37219
1 parent edd9951
commit bf37219
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/common/dev_vtty.c b/common/dev_vtty.c
@@ -569,13 +569,13 @@ void vtty_delete(vtty_t *vtty)
    int i;
 
    if (vtty != NULL) {
+      VTTY_LIST_LOCK();
       if (vtty->pprev != NULL) {
-         VTTY_LIST_LOCK();
          if (vtty->next)
             vtty->next->pprev = vtty->pprev;
          *(vtty->pprev) = vtty->next;
-         VTTY_LIST_UNLOCK();
       }
+      VTTY_LIST_UNLOCK();
 
       switch(vtty->type) {
            case VTTY_TYPE_TCP: