Merge pull request #150 from flaviojs/fix-descriptor-leaks-ppc32_load…

…_raw_image Fix resource leaks in ppc32_load_raw_image
GNS3 · Mar 9, 2024 · 9f60d7f · 9f60d7f
2 parents 00a91df + 15ecf3d
commit 9f60d7f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/stable/ppc32.c b/stable/ppc32.c
@@ -492,6 +492,7 @@ int ppc32_load_raw_image(cpu_ppc_t *cpu,char *filename,m_uint32_t vaddr)
 
    if (fstat(fileno(bfd),&file_info) == -1) {
       perror("stat");
+      fclose(bfd);
       return(-1);
    }
 
@@ -507,6 +508,7 @@ int ppc32_load_raw_image(cpu_ppc_t *cpu,char *filename,m_uint32_t vaddr)
       if (!haddr) {
          fprintf(stderr,"load_raw_image: invalid load address 0x%8.8x\n",
                  vaddr);
+         fclose(bfd);
          return(-1);
       }
 

diff --git a/unstable/ppc32.c b/unstable/ppc32.c
@@ -489,6 +489,7 @@ int ppc32_load_raw_image(cpu_ppc_t *cpu,char *filename,m_uint32_t vaddr)
 
    if (fstat(fileno(bfd),&file_info) == -1) {
       perror("stat");
+      fclose(bfd);
       return(-1);
    }
 
@@ -504,6 +505,7 @@ int ppc32_load_raw_image(cpu_ppc_t *cpu,char *filename,m_uint32_t vaddr)
       if (!haddr) {
          fprintf(stderr,"load_raw_image: invalid load address 0x%8.8x\n",
                  vaddr);
+         fclose(bfd);
          return(-1);
       }