-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide feedback that an ontology is being loaded #457
Comments
See PR here. |
garrettjstevens
pushed a commit
that referenced
this issue
Feb 7, 2025
garrettjstevens
added a commit
that referenced
this issue
Feb 7, 2025
* Use isTypeOf for checking equivalent types In `packages/apollo-mst/src/AnnotationFeatureModel.ts` we set the session onject to type `any` and ignore the warnings and ignore warning Add test file so_types.gff3 with unconventional types. * Fix lint * Add jobmanager for #457 * Avoid cloning function object * Showing progress report but: * The UI shows the job as still in progress even after the importing is done. This is because (?) we don't have a `jobsManager.done(job)` in packages/jbrowse-plugin-apollo/src/session/ClientDataStore.ts * We should show how far we are from completing the file import. * Add start, end, and a few progress updates * Report progress percent * Attempt loading so.json for testing * Some small fixes * Rename variables * Don't send sequence ontology until logged in --------- Co-authored-by: Garrett Stevens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Use the
jobsManager
in the (Apollo) session to update that an ontology is loading.We'll have to pass something into the OntologyManager to call updates with, like an
update
callback. We can then use that callback to adapt to thejobsManager
. e.g. something like this:You can see an example of how
jobsManager
is used inpackages/jbrowse-plugin-apollo/src/components/ImportFeatures.tsx
.The text was updated successfully, but these errors were encountered: