Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: "Add child feature" autocomplete not working, submit button is disabled #453

Open
garrettjstevens opened this issue Sep 24, 2024 · 3 comments · May be fixed by #459
Open

BUG: "Add child feature" autocomplete not working, submit button is disabled #453

garrettjstevens opened this issue Sep 24, 2024 · 3 comments · May be fixed by #459
Assignees

Comments

@garrettjstevens
Copy link
Contributor

Reported by EBI testers, the "Add child feature" feature type autocomplete is not working, and the submit button is disabled.

I think the likely culprit is that the ontology has not loaded correctly, but if that is the case we still need to:

  • Indicate in the UI why the autocomplete isn't working
  • Allow overriding the autocomplete with manual entry and submit
@garrettjstevens
Copy link
Contributor Author

A bit more info on how this might be done. In the OntologyTermAutocomplete, it uses the passed-in ontologyName to load the correct ontologyStore. If the store can't be found, the autocomplete could show an additional message saying something along the lines of `The '${ontologyName}' could not be found, suggestions are not available.`

const ontologyStore = ontologyManager.findOntology(
ontologyName,
ontologyVersion,
)?.dataStore

@garrettjstevens
Copy link
Contributor Author

After discussion today, we've decided that since #452 is going to make the feature type ontology (by default Sequence Ontology) an even more important part of our code, instead of the above approach we are going to not even display the Apollo track at all if there isn't a feature type ontology loaded. Instead we'll display a message saying that it needs a feature type ontology to run, which means users won't even be able to get to the autocomplete unless an ontology is loaded.

@dariober
Copy link
Contributor

dariober commented Oct 3, 2024

This below is what happens when trying to open an annotation track without sequence ontology. Message is a little basic just now...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

Successfully merging a pull request may close this issue.

2 participants