fix some warnings and leaks from overnight tests (#2377)

* fix some warnings and leaks from overnight tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

src/helics/application_api/Inputs.hpp

@@ -80,18 +80,18 @@ class HELICS_CXX_EXPORT Input: public Interface {
     Input(ValueFederate* valueFed,
           InterfaceHandle id,
           std::string_view actName,
-          std::string_view unitsOut = std::string{});
+          std::string_view unitsOut = {});
 
     Input(ValueFederate* valueFed,
           std::string_view key,
           std::string_view defaultType = "def",
-          std::string_view units = std::string{});
+          std::string_view units = {});
 
     template<class FedPtr>
     Input(FedPtr& valueFed,
           std::string_view key,
           std::string_view defaultType = "def",
-          std::string_view units = std::string{}):
+          std::string_view units = {}):
         Input(std::addressof(*valueFed), key, defaultType, units)
     {
         static_assert(
@@ -103,14 +103,14 @@ class HELICS_CXX_EXPORT Input: public Interface {
           ValueFederate* valueFed,
           std::string_view key,
           std::string_view defaultType = "def",
-          std::string_view units = std::string{});
+          std::string_view units = {});
 
     template<class FedPtr>
     Input(InterfaceVisibility locality,
           FedPtr& valueFed,
           std::string_view key,
           std::string_view defaultType = "def",
-          std::string_view units = std::string{}):
+          std::string_view units = {}):
         Input(locality, std::addressof(*valueFed), key, defaultType, units)
     {
         static_assert(
@@ -121,24 +121,21 @@ class HELICS_CXX_EXPORT Input: public Interface {
     Input(ValueFederate* valueFed,
           std::string_view key,
           DataType defType,
-          std::string_view units = std::string{}):
+          std::string_view units = {}):
         Input(valueFed, key, typeNameStringRef(defType), units)
     {
     }
 
     template<class FedPtr>
-    Input(FedPtr& valueFed,
-          std::string_view key,
-          DataType defType,
-          std::string_view units = std::string()):
+    Input(FedPtr& valueFed, std::string_view key, DataType defType, std::string_view units = {}):
         Input(valueFed, key, typeNameStringRef(defType), units)
     {
     }
 
     Input(InterfaceVisibility locality,
           ValueFederate* valueFed,
           std::string_view key,
-          std::string_view units = std::string{}):
+          std::string_view units = {}):
         Input(locality, valueFed, key, "def", units)
     {
     }
@@ -147,7 +144,7 @@ class HELICS_CXX_EXPORT Input: public Interface {
     Input(InterfaceVisibility locality,
           FedPtr& valueFed,
           std::string_view key,
-          std::string_view units = std::string{}):
+          std::string_view units = {}):
         Input(locality, valueFed, key, "def", units)
     {
     }
@@ -156,7 +153,7 @@ class HELICS_CXX_EXPORT Input: public Interface {
           ValueFederate* valueFed,
           std::string_view key,
           DataType defType,
-          std::string_view units = std::string{}):
+          std::string_view units = {}):
         Input(locality, valueFed, key, typeNameStringRef(defType), units)
     {
     }
@@ -166,7 +163,7 @@ class HELICS_CXX_EXPORT Input: public Interface {
           FedPtr& valueFed,
           std::string_view key,
           DataType defType,
-          std::string_view units = std::string{}):
+          std::string_view units = {}):
         Input(locality, valueFed, key, typeNameStringRef(defType), units)
     {
     }

src/helics/network/zmq/ZmqCommsCommon.cpp

@@ -28,7 +28,7 @@ bool bindzmqSocket(zmq::socket_t& socket,
             socket.bind(gmlc::networking::makePortAddress(address, port));
             bindsuccess = true;
         }
-        catch (const zmq::error_t& ze) {
+        catch (const zmq::error_t& /*ze*/) {
             if (tcount == milliseconds{0}) {
                 // std::cerr << "zmq binding error on socket sleeping then will try again \n";
             }

src/helics/shared_api_library/ValueFederateExport.cpp

@@ -21,9 +21,9 @@ static constexpr int InputValidationIdentifier = 0x3456'E052;
 /** random integer for validation purposes of publications */
 static constexpr int PublicationValidationIdentifier = 0x97B1'00A5;
 
-static constexpr char* invalidInputString = "The given input object does not point to a valid object";
+static constexpr const char* invalidInputString = "The given input object does not point to a valid object";
 
-static constexpr char* invalidPublicationString = "The given publication object does not point to a valid object";
+static constexpr const char* invalidPublicationString = "The given publication object does not point to a valid object";
 
 static helics::InputObject* verifyInput(HelicsInput inp, HelicsError* err)
 {

tests/helics/shared_library/DataAPITests.cpp

@@ -251,4 +251,5 @@ TEST(data, clone)
 
     v2 = helicsDataBufferToDouble(newbuff);
     EXPECT_EQ(v1, v2);
+    helicsDataBufferFree(newbuff);
 }

tests/helics/shared_library/SystemTests.cpp

@@ -572,6 +572,7 @@ TEST(federate, federateNoProtection)
 
     EXPECT_FALSE(helicsFederateIsValid(fedFind));
     EXPECT_NE(err.error_code, 0);
+    helicsFederateInfoFree(fi);
 }
 
 TEST(federate, federateProtection)
@@ -582,7 +583,7 @@ TEST(federate, federateProtection)
     helicsFederateInfoSetCoreInitString(fi, "-f 1 --autobroker --error_timeout=0", nullptr);
 
     auto fed1 = helicsCreateValueFederate("fed1", fi, nullptr);
-
+    helicsFederateInfoFree(fi);
     helicsFederateEnterExecutingMode(fed1, nullptr);
 
     std::string fed1Nm = helicsFederateGetName(fed1);

tests/helics/system_tests/iterationTests.cpp

@@ -905,11 +905,11 @@ TEST_F(iteration, iteration_high_count_nocov_ci_skip_nosan)
     auto vFed2 = GetFederateAs<helics::ValueFederate>(1);
 
     auto& pub1_1 = vFed1->registerGlobalPublication<int>("pub1_1");
-    auto& sub1_1 = vFed1->registerSubscription("pub2_1");
+    vFed1->registerSubscription("pub2_1");
 
     auto& pub2_1 = vFed2->registerGlobalPublication<int>("pub2_1");
 
-    auto& sub2_1 = vFed2->registerSubscription("pub1_1");
+    vFed2->registerSubscription("pub1_1");
 
     vFed2->enterInitializingModeAsync();
     vFed1->enterInitializingMode();