Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix same_op_2 test expectation #97

Closed
wants to merge 1 commit into from
Closed

Fix same_op_2 test expectation #97

wants to merge 1 commit into from

Conversation

McSinyx
Copy link
Contributor

@McSinyx McSinyx commented Nov 18, 2024 •
edited
Loading

For convenient reference, same_op_2 prints instructions matching src[1] == dst[0].

@GJDuck
Copy link
Owner

GJDuck commented Dec 4, 2024

+ sqrtss %xmm0, %xmm1

This does not look correct. The src[1] operand should be undefined for this instruction.

Which version of Zydis are you using?

@McSinyx
Copy link
Contributor Author

McSinyx commented Dec 6, 2024

Sorry for the noise, I think it's indeed a bug from Zydis 4.1.0: both operands are disassembled as to be read, but even if that's the case, src[1] == dst[0] shouldn't hold.

@McSinyx McSinyx closed this Dec 6, 2024
@McSinyx McSinyx deleted the test-src1-dst0 branch December 6, 2024 09:43
@McSinyx McSinyx mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@McSinyx @GJDuck