Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export endpoint #269

Merged
merged 26 commits into from
Oct 18, 2024
Merged

Add export endpoint #269

merged 26 commits into from
Oct 18, 2024

Conversation

merydian
Copy link
Collaborator

@merydian merydian commented Jul 6, 2024

Extent choosable via QgsProcessingParameterExtent.

@merydian
Copy link
Collaborator Author

merydian commented Jul 6, 2024

Should we wait for this to be available in the public API?

@merydian merydian requested a review from koebi July 6, 2024 19:39
@merydian merydian marked this pull request as ready for review July 6, 2024 19:39
@merydian
Copy link
Collaborator Author

merydian commented Jul 6, 2024

Translation still missing.

@merydian merydian linked an issue Jul 6, 2024 that may be closed by this pull request
Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far :)

Translation is missing @koebi

Comment on lines 116 to 117
to_coords = self.get_location_by_id(to_id, response["nodes"])
from_coords = self.get_location_by_id(from_id, response["nodes"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This iterates all nodes twice for every edge, taking what is in theory a linear operation and making it quadratic.

I think it makes sense to parse nodes into a dict to look up coordinates easily.

@koebi
Copy link
Collaborator

koebi commented Sep 18, 2024

After testing for a bit, I think it makes sense to also export nodes into a separate layer - it's a bit too tricky from my perspective to correctly parse them from the edge layer.

@koebi koebi merged commit 8687fe3 into main Oct 18, 2024
5 checks passed
@koebi koebi deleted the add-export-endpoint branch October 18, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add network export endpoint
2 participants