Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: attendance mode #1973

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LuukBlankenstijn
Copy link

  • Docker bind mount for development
  • Stimulus support
  • Typescript support
  • Add attendance mode where activity admins can take attendance of participants

Description

Started working on attendance mode. Really wanted to use Stimulus, so added it, including typescript. Then while developing I got really frustrated by the constant rebuilding of the dev container to see changes, so changed it, so now the host system is mounted in the docker container. This means changes will take effect immediately, without doing anything. It made the development experience a lot nicer.

The feature I added was the attendance mode. In the admin-overview of an activity at a signup-list, there is now a button 30 minutes before to 30 minutes after the activity that allows the user to go into signup mode.
image
Here they can search for participants that have not been marked present yet and mark them present. This will be send to the server. The server will respond with information to sync the list in the client. Since I did most of it in the frontend with Stimulus, the UI is really responsive.

All of this happened kind of at the same time, this is the reason it is combined in one pull request. Separating it would take an immense amount of time.

Related issues/external references

Fixes issue GH-1921

Fixes GH-NNN.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (no changes to code)
  • Dev-environment

@LuukBlankenstijn LuukBlankenstijn force-pushed the feature/take-attendance-at-activities branch 4 times, most recently from 7791f15 to d968043 Compare January 18, 2025 15:05
- Docker bind mount for development
- Stimulus support
- Typescript support
- Add attendance mode where activity admins can take attendance of
  participants
@LuukBlankenstijn LuukBlankenstijn force-pushed the feature/take-attendance-at-activities branch from d968043 to 4b5493d Compare January 18, 2025 15:09
@tomudding tomudding self-requested a review January 20, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant