fix(photo): combination of week number and year being wrong #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Week number is based on ISO 8601, which allows January 1 to fall on Mon-Thu for that week to be the first week of the year. However, we cannot get the year from the date itself, because if (for example for this year) that date still falls in December the year is one year too low.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Week number is based on ISO 8601, which allows January 1 to fall on Mon-Thu for that week to be the first week of the year. However, we cannot get the year from the date itself, because if (for example for this year) that date still falls in December the year is one year too low.
Related issues/external references
Fixes GH-1966.
Types of changes