chore: optimise GEWIS logo in error pages #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I created this using a base64-encoded PNG URI was the easiest, however, the URI is more than 30k characters. Doing it with the SVG makes it scale better and is only 1.5k characters (unfortunately, the URL encoding is necessary). That is a reduction of 95%. --- The real reason for doing is is that I have been working on the custom error pages for the CBC and needed the optimisations for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I created this using a base64-encoded PNG URI was the easiest, however, the URI is more than 30k characters. Doing it with the SVG makes it scale better and is only 1.5k characters (unfortunately, the URL encoding is necessary). That is a reduction of 95%.
The real reason for doing is is that I have been working on the custom error pages for the CBC and needed the optimisations for that.
Types of changes