feat: dynamically evaluate page access permissions #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of loading all pages as separate resources into the ACL, we dynamically evaluate whether someone may access the page or not. A visitor can access a page if they have the required role or if they inherit the required role.
github-actions bot
added a commit
that referenced
this pull request
Dec 29, 2024
Tom Udding: Merge pull request #1953 from tomudding/feature/improved-custom-page-authorization-checks feat: dynamically evaluate page access permissions Co-authored-by: tomudding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of loading all pages as separate resources into the ACL, we dynamically evaluate whether someone may access the page or not.
A visitor can access a page if they have the required role or if they inherit the required role.
In reality, this only removes one query, but that query has been removed from all requests.
Related issues/external references
Closes GH-1952.
Types of changes