chore: move everything to factories #1951
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomudding
force-pushed
the
chore/move-to-factories
branch
2 times, most recently
from
04d8774 to
256c294
Compare
tomudding
force-pushed
the
chore/move-to-factories
branch
from
256c294 to
8bd4c62
Compare
|
Bit brain-dead (if I was not already) from repetitively creating so many files. Unfortunately, I just remembered that most of the factories are not needed at all because all mappers can use a common factory, and so can most forms (the ones that only need a translator). Psalm errors about |
Moves _everything_ to factories (except some things that require duplication in the `Education` and `User` module).
tomudding
force-pushed
the
chore/move-to-factories
branch
from
8bd4c62 to
40b1e42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues/external references
Closes GH-1824.
Types of changes