feat: improved album covers #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help on mobile devices to prevent you from being able to count the number of pixels. Now that they are a bit larger, it makes sense to move them to Glide to make them smaller 🤯.
github-actions bot
added a commit
that referenced
this pull request
Dec 14, 2024
Tom Udding: Merge pull request #1944 from tomudding/feature/improved-album-thumbnails feat: improved album covers Co-authored-by: tomudding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where a 2px-wide border was added around album covers (only noticed it last night after moving albums to the card grid system).
Moves album covers to Glide for caching and processing and made album covers larger (such that you cannot count the pixels on mobile devices).
Types of changes