Fix to solve issue of leaving page during upload of images #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomudding
requested changes
Mar 28, 2024
Comment on lines
+101
to
+105
| // Most modern browsers no longer support setting custom dialog messages | ||
| // for this dialog, but for backwards compatibility this could be nice. | ||
| const warning = "You are currently uploading files, are you sure you want to leave?"; | ||
| e.returnValue = warning; | ||
| return warning; |
There was a problem hiding this comment.
This works great! However, I suggest adding
e.preventDefault();at the top inside the if-statement. That is the new way of actually enabling this event. The other options, setting e.returnValue and returning warning, are deprecated (imho the return warning; can be removed as e.returnValue has been supported in most major browsers since 2017 or earlier).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135
Just a fix to make it not leave the page when uploading pictures to albums. (or atleast give a warning)