Improved markdown support for companies #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilises the new MarkdownCompanyEditor that also allows photos to be uploaded and videos to be inserted. Files from each company are now stored in a company specific folder to prevent these files from overwriting other files (either those from GEWIS itself or other companies). IMPORTANT: files are stored based on the ID of the company not the slug. This is because the slug can change and the ID should not change.
Prevents image injection into Markdown when we do not want to show images. For example, in activity descriptions or new items. However, for companies this is useful. The images go through Glide! Furthermore, a new renderer has been added that can render YouTube and Vimeo videos.
tomudding
force-pushed
the
feature/improved-markdown-support-for-companies
branch
from
c0022d3 to
86af1b4
Compare
github-actions bot
added a commit
that referenced
this pull request
Feb 6, 2024
Tom Udding: Merge pull request #1785 from tomudding/feature/improved-markdown-support-for-companies Improved markdown support for companies Co-authored-by: tomudding <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description editors in the company module now use a special Markdown editor tailored to companies. This means that it is possible to upload images and insert videos. To make this possible, several CommonMark extensions have been added to our setup.
This also separates uploads per companies and ensures that images are not rendered in non-company markdown views.
Closes GH-1781, fixes GH-1780, closes GH-1759, and closes GH-1576.