Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add similar courses in course page #1727

Merged
merged 8 commits into from
Oct 6, 2023
Merged

Add similar courses in course page #1727

merged 8 commits into from
Oct 6, 2023

Conversation

JortvD
Copy link
Contributor

@JortvD JortvD commented Oct 4, 2023

Created to solve #1726

@Koen1999
Copy link
Contributor

Koen1999 commented Oct 4, 2023

Is there a way to populate $similarCoursesFrom in the model?

@tomudding tomudding marked this pull request as draft October 4, 2023 11:48
@JortvD
Copy link
Contributor Author

JortvD commented Oct 5, 2023

Is there a way to populate $similarCoursesFrom in the model?

I have to preface that I'm a bit new to Doctrine ORM, but isn't it the case that $similarCoursesFrom is populated due to the fact it is the inverse of $similarCoursesTo? So if entries are added to the SimilarCourse table it will populate the related collections for those courses.

@tomudding tomudding marked this pull request as ready for review October 5, 2023 12:54
@JortvD JortvD force-pushed the feature/education-similar branch from 3621f6c to 49bc894 Compare October 5, 2023 13:00
@JortvD JortvD force-pushed the feature/education-similar branch from 49bc894 to 1b13555 Compare October 5, 2023 13:03
@tomudding tomudding self-requested a review October 5, 2023 13:03
@tomudding tomudding force-pushed the feature/education-similar branch from 6ba00e7 to 74036dd Compare October 6, 2023 17:20
tomudding
tomudding approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@tomudding tomudding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @JortvD! Because you will be using this interface it is fine for now, however, I do think we should make the selection process of courses easier in the future. For example, with an auto-complete search function.

@tomudding tomudding merged commit c17c980 into GEWIS:main Oct 6, 2023
4 checks passed
@tomudding tomudding mentioned this pull request Oct 6, 2023
Closed
github-actions bot added a commit that referenced this pull request Oct 6, 2023
@github-actions @tomudding
Deploy docs from c17c980
c753288 
Tom Udding: Merge pull request #1727 from JortvD/feature/education-similar

Add similar courses in course page

Co-authored-by: tomudding <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koen1999 Koen1999 Koen1999 left review comments

@tomudding tomudding tomudding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JortvD @Koen1999 @tomudding