wip: improved OrganInformation approval
#1209
Annotations
10 errors and 9 warnings
|
Run PHP_CS:
module/Decision/src/Controller/OrganAdminApprovalController.php#L7
Type Application\Form\ModifyRequest (as RequestForm) is not used in this file.
|
|
Run PHP_CS:
module/Decision/src/Controller/OrganAdminApprovalController.php#L8
Type Application\Model\Enums\ApprovableStatus is not used in this file.
|
|
Run PHP_CS:
module/Decision/src/Controller/OrganAdminApprovalController.php#L12
Type Laminas\Http\Request is not used in this file.
|
|
Run PHP_CS:
module/Decision/src/Hydrator/OrganInformation.php#L33
Method \Decision\Hydrator\OrganInformation::hydrate() does not have @param annotation for its traversable parameter $data.
|
|
Run PHP_CS:
module/Decision/src/Controller/Factory/OrganAdminApprovalControllerFactory.php#L17
Method \Decision\Controller\Factory\OrganAdminApprovalControllerFactory::__invoke() does not have native type hint for its parameter $requestedName but it should be possible to add it based on @param annotation "string".
|
|
Run PHP_CS:
module/Decision/src/Model/OrganInformation.php#L121
@var annotation of property \Decision\Model\OrganInformation::$updateProposals does not specify type hint for its items.
|
|
Run PHP_CS:
module/Decision/src/Model/OrganInformation.php#L198
Method \Decision\Model\OrganInformation::getUpdateProposals() does not have @return annotation for its traversable return value.
|
|
Run PHP_CS:
module/Decision/src/Controller/OrganAdminController.php#L7
Type Decision\Model\OrganInformation (as OrganInformationModel) is not used in this file.
|
|
Run PHP_CS:
module/Decision/src/Service/Organ.php#L284
Use early exit to reduce code nesting.
|
|
Run PHP_CS:
module/Decision/src/Mapper/Member.php#L16
Use statements should be sorted alphabetically. The first wrong one is Doctrine\ORM\QueryBuilder.
|
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Run PHP_CS:
module/Application/src/Extensions/CommonMark/VideoIframe/Parsers/VimeoUrlParser.php#L16
Line exceeds 120 characters; contains 197 characters
|
|
Run PHP_CS:
module/Application/src/Extensions/CommonMark/VideoIframe/Parsers/YouTubeUrlParser.php#L16
Line exceeds 120 characters; contains 133 characters
|
|
Run PHP_CS:
module/Photo/src/Mapper/Tag.php#L64
Line exceeds 120 characters; contains 131 characters
|
|
Run PHP_CS:
module/Photo/src/Form/Album.php#L97
Line exceeds 120 characters; contains 135 characters
|
|
Run PHP_CS:
module/Application/src/Command/LoadFixtures.php#L55
Line exceeds 120 characters; contains 122 characters
|
|
Run PHP_CS:
module/Application/src/View/HelperTrait.php#L36
Line exceeds 120 characters; contains 129 characters
|
|
Run PHP_CS:
module/Application/src/View/HelperTrait.php#L38
Line exceeds 120 characters; contains 167 characters
|
|
Run PHP_CS:
module/Decision/src/Service/Gdpr.php#L50
Line exceeds 120 characters; contains 131 characters
|
Loading