Accumulator Additional Tests and Fixes #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darianboggs
added
🎁 New Feature
tclune
reviewed
Nov 12, 2024
tclune
reviewed
Nov 12, 2024
tclune
reviewed
Nov 12, 2024
|
I understand. But why not use the mechanism that the rest of MAPL tests are using in this regard? I'm not doubting that it will work. |
|
Pushed update with changes to accumulator action names and base branch update |
|
Waiting for tests (local) to finish to push up update to base branch. |
|
I don't know why GEOSadas tests are failing, but I assume they are not fatal. |
They are random and unrelated to any MAPL3 code. And yes, very annoying. |
tclune
reviewed
Nov 13, 2024
tclune
approved these changes
Nov 13, 2024
tclune
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
This PR provides additional tests for AccumlatorAction and the types derived from it. Also, it includes fixes to AccumulatorAction and derived types in response to tests.
Related Issue