Bug fix in FieldSpec::adapt_vertical_grid

[pchakraborty]

Types of change(s)

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Trivial change (affects only documentation or cleanup)
• Refactor (no functional changes, no api changes)

Checklist

• Tested this change with a run of GEOSgcm
• Ran the Unit Tests (make tests)

Description

Fixed a bug where the wrong units (of the field to be regridded, instead of the units of the vertical grid), was being passed to VerticalGrid::get_coordinate_field. This necessitated several related changes

• Added class variable units and its accessors to VerticalGrid

Note

This causes the issue that DYN will now need to define two vertical grids - one for pressure and another for height. Maybe that's okay, but needs further consideration.

• Updated ComponentSpecParser::parse_geometry_spec where the ModelVerticalGrid gets created
• Updated Test_ModelVerticalGrid.pf
• Added a Scenarios test vertical_regridding_3 where component A (Model vertical grid) exports PL (hPa) and E_A (K) which are in turn imported by components B and C (FixedLevels vertical grid)

Also

• Updated the type of the levels(:) array in FixedLevelsVerticalGrid: real32 -> ESMF_TYPEKIND_R4
• Catching exceptions for adapter match and adapt methods
• Updated Test_Scenarios.pf to deactivate vertical_regridding_2/3 tests only for gfortran builds

Related Issue