Skip to content

add make_topo scripts to generate topography files on BC #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Feb 7, 2025

Add make_topo scripts to generate topography files on BC.

PR needs this topo branch to work for stretched grids:
GEOS-ESM/Topo#1

@weiyuan-jiang weiyuan-jiang added enhancement New feature or request 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Feb 7, 2025
@biljanaorescanin
Copy link
Contributor

biljanaorescanin commented May 31, 2025

Summary of code testing: Screenshot 2025-05-31 at 9 04 24 AM
In general most runs will finish in less then 1h but c90, c2160 and c2880 need ~3h. Since segments for overlap weights are dynamically determined runs will not be zero diff to itself but roundoff. Why we have different results for regular grid to before? I've implemented Girard formula with bounds checking which computes angles more accurately.

@wmputman do these numbers look OK to you? All verification on my side global plots/zoom in plots look ok. I've created a directory you can use to test to see do output files behave as you expect. I also tried fix you suggested for c5760 but it didn't work. Maybe SI-Team can figure that one out.

@biljanaorescanin biljanaorescanin marked this pull request as ready for review May 31, 2025 15:45
@biljanaorescanin biljanaorescanin requested review from a team as code owners May 31, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants