-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to OpenACC libs if GPU_PHYSICS option is set #482
Draft
pchakraborty
wants to merge
7
commits into
develop
Choose a base branch
from
merge/pchakrab/gpu-physics-openacc
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b4d20b4
Merge pull request #458 from GEOS-ESM/develop
mathomp4 d76cb93
Merge pull request #463 from GEOS-ESM/develop
sdrabenh 2b1e0a7
Merge pull request #465 from GEOS-ESM/develop
mathomp4 784002c
Merge pull request #472 from GEOS-ESM/develop
sdrabenh 576be32
Added link flags for GPU Physics (OpenACC)
pchakraborty d7fb999
Merge branch 'develop' into merge/pchakrab/gpu-physics-openacc
pchakraborty 60b5122
Using variables instead of hardcoding flags
pchakraborty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pchakraborty This might be better as a variable or set of variables in ESMA_cmake in
compiler/flags/GNU_Fortran.cmake
. That way if you need to reuse them anywhere they can be (not sure you will, but just in case).Note that if you do that, you might as well do it in GEOS-ESM/ESMA_cmake#322, but you might have to move up your
GPU_PHYSICS
option in there to before we do the### Compiler Support ###
bits.