-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to pyFV3/NDSL structure & better interface #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add except catch and error properly Start fixing Wrapper to work without namelist
Remove namelist MetricTerms using ak/bk data
Add bad tracer count raise
Add `pyFV3_interface` as the entry point
Better README
FlorianDeconinck
added
the
0 diff structural
Structural changes to repository that are zero-diff
label
Apr 18, 2024
gmao-ckung
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Following a refactor of the Pace repository, the system has been broken into parts to ease the transition to middleware driven development.
We now reference the pyFV3 code, NDSL port of FVDycore shared with NOAA.
The interface has been refactored:
pyfv3
instead ofgtfv3
python/*
to normalize code structure going forwardDependencies
Requires
ndsl
version2024.04.00
, which will be deployed onDiscover
next.