Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pyFV3/NDSL structure & better interface #278

Merged
merged 16 commits into from
Apr 18, 2024

Conversation

FlorianDeconinck
Copy link
Collaborator

In this PR

Following a refactor of the Pace repository, the system has been broken into parts to ease the transition to middleware driven development.

We now reference the pyFV3 code, NDSL port of FVDycore shared with NOAA.

The interface has been refactored:

  • stream in configuration of FV, removing reliance on namelist
  • refactor code to reference pyfv3 instead of gtfv3
  • move code into python/* to normalize code structure going forward
  • better README
  • clean up dead code

Dependencies

Requires ndsl version 2024.04.00, which will be deployed on Discover next.

@FlorianDeconinck FlorianDeconinck added the 0 diff structural Structural changes to repository that are zero-diff label Apr 18, 2024
@FlorianDeconinck FlorianDeconinck requested review from a team as code owners April 18, 2024 17:04
Copy link

@gmao-ckung gmao-ckung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@FlorianDeconinck FlorianDeconinck merged commit 09582d1 into dsl/develop Apr 18, 2024
19 checks passed
@FlorianDeconinck FlorianDeconinck deleted the feature/update_to_pyFV3 branch April 18, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff structural Structural changes to repository that are zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants