Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS - Material Symbols / Dark Mode plugin. #1859

Open
wants to merge 94 commits into
base: minor
Choose a base branch
from

Conversation

cityremade
Copy link
Member

@cityremade cityremade commented Jan 30, 2025

Mask icon block vector symbols now replaced with inline Material Icons.
Dark Mode plugin included in core.
HTML in ui elements simplified where possible.

Dark mode CSS in one stylesheet ordered by components. Can be removed when no longer needed.

This PR requires review along with v4.13.0 update to relevant plugins.

Included material icons font stylesheet.
.mask-icon class no longer in use in default view;
Default mask icon class now replaced with default material symbols;
Also better symbol on card element;
@cityremade cityremade added Code Issues related to the code structure and performance. CSS Changes in stylesheets labels Jan 30, 2025
@cityremade cityremade self-assigned this Jan 30, 2025
@cityremade cityremade marked this pull request as ready for review January 31, 2025 10:03
@dbauszus-glx dbauszus-glx changed the title CSS - Material Symbols in full flow and Dark Mode plugin now included in core. CSS - Material Symbols / Dark Mode plugin. Jan 31, 2025
Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The darkmode plugin doesn't work.

image

@dbauszus-glx
Copy link
Member

Some of the changes from this PR seem to be reversed. For example the integrity check for script src in the default view.

#1849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance. CSS Changes in stylesheets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

review mask-icon use within plugins mask-icon class clean up;
3 participants