-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS - Material Symbols / Dark Mode plugin. #1859
Open
cityremade
wants to merge
94
commits into
GEOLYTIX:minor
Choose a base branch
from
cityremade:dark_mode_plugin
base: minor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default mask icon class now replaced with default material symbols;
Also better symbol on card element;
cityremade
added
Code
Issues related to the code structure and performance.
CSS
Changes in stylesheets
labels
Jan 30, 2025
This was
linked to
issues
Jan 30, 2025
cityremade
requested review from
dbauszus-glx,
AlexanderGeere,
RobAndrewHurst and
simon-leech
January 31, 2025 10:03
dbauszus-glx
changed the title
CSS - Material Symbols in full flow and Dark Mode plugin now included in core.
CSS - Material Symbols / Dark Mode plugin.
Jan 31, 2025
dbauszus-glx
requested changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the changes from this PR seem to be reversed. For example the integrity check for script src in the default view. |
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mask icon block vector symbols now replaced with inline Material Icons.
Dark Mode plugin included in core.
HTML in ui elements simplified where possible.
Dark mode CSS in one stylesheet ordered by components. Can be removed when no longer needed.
This PR requires review along with v4.13.0 update to relevant plugins.