Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MVT reload doesn't refresh source #1626

Merged
merged 2 commits into from
Oct 30, 2024
Merged

MVT reload doesn't refresh source #1626

merged 2 commits into from
Oct 30, 2024

Conversation

dbauszus-glx
Copy link
Member

This is a workaround for the issue until resolved in the OL library.

@dbauszus-glx dbauszus-glx added the Bug A genuine bug. There must be some form of error exception to work with. label Oct 29, 2024
@dbauszus-glx dbauszus-glx self-assigned this Oct 29, 2024
@dbauszus-glx dbauszus-glx linked an issue Oct 29, 2024 that may be closed by this pull request
MVT reload doesn't request tiles from source. #1624
Open
AlexanderGeere
AlexanderGeere previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@AlexanderGeere AlexanderGeere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trie it on bugs_testing/mvt_edit.json Looks good to me!

AlexanderGeere
AlexanderGeere approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@AlexanderGeere AlexanderGeere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it on bugs_testing/mvt_edit.json Looks good to me!

RobAndrewHurst
RobAndrewHurst approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@RobAndrewHurst RobAndrewHurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good for me!

@RobAndrewHurst RobAndrewHurst merged commit 80a5bdc into GEOLYTIX:main Oct 30, 2024
3 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dbauszus-glx dbauszus-glx deleted the mvt-vectortile-source-refresh branch November 27, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-leech simon-leech simon-leech approved these changes

@RobAndrewHurst RobAndrewHurst RobAndrewHurst approved these changes

@AlexanderGeere AlexanderGeere AlexanderGeere approved these changes

@cityremade cityremade Awaiting requested review from cityremade

Assignees

@dbauszus-glx dbauszus-glx

Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MVT reload doesn't request tiles from source.
4 participants
@dbauszus-glx @AlexanderGeere @RobAndrewHurst @simon-leech