Update changes to get code running on Python 3 using antlr_python3_runtime-3.1.3. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.next()` has been replaced with `next()` in Python 3. Fixed.
…)`. Updated `except` to use `as` keywords.
Replaced Python 2 `isinstance(x, file)` with Python 3 `isinstance(x, io.IOBase)`. Fixed.
Python 3 no longer allows `file` in isinstance(), updated to use `io.IOBase`. Fixed.
Python 3 requires `as` keyword in `except`, in place of comma separator. Fixed.
`_levelNames` has been replaced with `_nameToLevel` in `logging`. Fixed.
Changed `print 'IOError: %s.' % (msg, )` to `print(f'IOError: {msg}.')`
…>>` to `file=` syntax. Update Python 2 `print` statements to Python 3 `print()`, including `>>` to `file=` syntax. Python 2 `print >> fd, str` syntax is now `print(str, file=fd)` in Python 3. Implemented f-strings where relevant for these.
… 3 `antlr-python3-runtime-3.1.3`. `setup.py` has been changed to install from `https://github.com/GEGlobalResearch/java2python/archive/master.zip` and with the `antlr_python_runtime` from `https://github.com/altigee/antlr-python3-runtime-3.1.3/archive/master.zip`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should bring the code up to a functional state for Python 3.8, including the retrieval of an antlr_python_runtime updated for Python 3.
Downloading the archive and executing
pip install .from within the file directory of the downloaded target should, using this setup.py, install:java2pythonantlr_python3_runtime-3.1.3(asantlr_python_runtimefor dependency andantlr3as package)[from https://github.com/altigee/antlr-python3-runtime-3.1.3/archive/master.zip]
It's worth noting that Issue natural#62 on the upstream repo is still present, but seems to have an unincorporated fix, in PR natural#32 on that repo, that does seem to work.