Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented tkinter graphics on Linux #303

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

sdasda7777
Copy link
Contributor

The tkinter library is very common and supports all the same features that yad does.

@sdasda7777
Copy link
Contributor Author

Note that the diff seems to be misleading at some places.

@twoln
Copy link
Contributor

twoln commented Jun 21, 2024

This is really great. I see just one small problem. On the final screen where you ask for credentials there is a Login button for confirmation with the "Login" text hard-coded. If it is not possible to call a system "OK" button like in other commands, then could you please add
ok = "OK" to the Messages class and just use it instead of the Login. I will then add a definition to DeviceLinux.php so we can use a translation of this OK (might be necessary for non-latin languages).
Other than that all looks great an I will be able to merge.

@sdasda7777
Copy link
Contributor Author

I see, I forgot about that. Unfortunately, I wasn't able to find any way to load this from the locale. I will add the string, of course.

@twoln twoln merged commit c9676c6 into GEANT:release_2_1 Jun 21, 2024
9 checks passed
@sdasda7777
Copy link
Contributor Author

Thanks!

@twoln
Copy link
Contributor

twoln commented Oct 7, 2024

I have run some tests. Are you sure that tinker should be preferred over zenity? The look of zenity seems to be so much nicer. I would say zenity, tkinter, dialog, tty

@sdasda7777
Copy link
Contributor Author

Are you sure that tinker should be preferred over zenity?

I personally don't care about this too much, and I think in practice both would work. However I should note that tkinter is technically more robust, as it returns the user input exactly as it was given, whereas reading zenity and yad correctly depends on user not entering a specific sequence into any given field (currently it's 5 consecutive newlines, if I recall correctly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants