-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented tkinter graphics on Linux #303
Conversation
Note that the diff seems to be misleading at some places. |
This is really great. I see just one small problem. On the final screen where you ask for credentials there is a Login button for confirmation with the "Login" text hard-coded. If it is not possible to call a system "OK" button like in other commands, then could you please add |
I see, I forgot about that. Unfortunately, I wasn't able to find any way to load this from the locale. I will add the string, of course. |
Thanks! |
I have run some tests. Are you sure that tinker should be preferred over zenity? The look of zenity seems to be so much nicer. I would say zenity, tkinter, dialog, tty |
I personally don't care about this too much, and I think in practice both would work. However I should note that tkinter is technically more robust, as it returns the user input exactly as it was given, whereas reading zenity and yad correctly depends on user not entering a specific sequence into any given field (currently it's 5 consecutive newlines, if I recall correctly). |
The tkinter library is very common and supports all the same features that yad does.