Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(majorUtils getDepartmentIdByMajor): 특정 학과의 경우 공지사항 조회 및 알림설정이 불가했던 문제 해결 #183

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

pp449
Copy link
Member

@pp449 pp449 commented Feb 4, 2024

🤠 개요

💫 설명

문제 발생원인

image 해당 학과로 가정한다면 `스마트헬스케어학부 해양스포츠전공` 이지만 길이가 너무 길어 `해양스포츠전공`으로 로컬 스토리지 저장되도록 되어있었어요

하지만 서버의 경우 스마트헬스케어학부 해양스포츠전공 값 전체를 받아야 처리할 수 있었던 문제가 있었기에 해양스포츠전공 만 받아도 처리될 수 있도록 수정했어요

📷 스크린샷 (Optional)

@pp449 pp449 added the 🛠 fix label Feb 4, 2024
@pp449 pp449 self-assigned this Feb 4, 2024
Copy link
Collaborator

@hwinkr hwinkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@pp449 pp449 merged commit 9396fbe into dev Feb 6, 2024
1 check passed
@pp449 pp449 deleted the fix/#181 branch February 6, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: 특정 학과의 경우 학과 입력이 제대로 안되는 문제
2 participants