양유나 API 구축 코드 #17
Open
양유나 API 구축 코드 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coke98
reviewed
Jun 23, 2024
| private String email; | ||
| private String password; | ||
|
|
||
| // Getters and Setters |
| @GetMapping("/{email}") | ||
| public User getUserByEmail(@PathVariable String email) { | ||
| Optional<User> user = users.stream().filter(u -> u.getEmail().equals(email)).findFirst(); | ||
| return user.orElse(null); |
There was a problem hiding this comment.
optional을 활용한 점은 좋았습니다만, 응답에 null을 주는게 좋을지 고민해봐도 좋을 것 같습니다.
null로 리턴값을 처리하는 것보다. default 값이나, 상태코드로 상태를 알리는 건 어떨까요?
추후 프로젝트에서는 orElseThrow를 사용해서 예외를 던져주는 방식도 있으니 활용해보셔도 좋을 것 같아요
mjj111
approved these changes
Jun 23, 2024
| Iterator<User> iterator = users.iterator(); | ||
| while (iterator.hasNext()) { | ||
| User user = iterator.next(); | ||
| if (user.getEmail().equals(email)) { |
There was a problem hiding this comment.
getEmail로 꺼내와서 비교하는것 보다는 user.sameEmail() 로 하나 만들어서 적용하는 것도 좋을 것 같아요
| private String email; | ||
| private String password; | ||
|
|
||
| // Getters and Setters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LuckyNumberController: 숫자 1~9 중 랜덤으로 숫자 1개를 반환
UserController: 사용자 등록, 조회, 삭제