박세찬 API 구현 코드입니다! #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat#1:User Check
Feat#3:Get Quiz
Feat#4:Quiz response
Fix:Quiz response error
|
Postman 요청, 응답 결과와 동작 원리 노션 페이지입니다! |
coke98
reviewed
Jun 23, 2024
| public Quiz getQuiz() { | ||
| return quiz; | ||
| } | ||
| @PostMapping |
There was a problem hiding this comment.
현재는 url만 봤을때 퀴즈를 만드는 걸로도 해석될 수 있을 것 같아요~ 도메인 내에 Url들이 많아지기 시작하면, 명확히 구분해야할 필요성이 높아지곤 합니다.
post /quiz/submission 과 같이 어떤 자원을 Post하는지 정확히 명시하기위해 고민해본다면 좀 더 restful한 url 네이밍으로 협업이 가능할 수도 있을 것 같아요 :)
| users.add(new User(request.getName(), request.getAge())); | ||
| } | ||
|
|
||
| @GetMapping("/User") |
There was a problem hiding this comment.
모든 유저를 가져온다면 /users가 좀 더 명확하지 않을까 싶네요. 협업하는 프론트 개발자 입장에서는 특정 유저 정보를 가져오는 것으로 이해할 수 있을 것 같아요. 추가로 소문자를 사용하는 것이 네이밍 원칙입니답
| public class QuizSubmission { | ||
| private String selectedAnswer; | ||
|
|
||
| public QuizSubmission(){} |
There was a problem hiding this comment.
바인딩을 위해서 기본생성자를 필요로 하는데요, 원래는 자동 생성이 되지만,,, 이미 다른 생성자가 있다면 세찬님처럼 기본생성자를 명시하지 않는 이상 생성이 되지 않습니다. 이 문제도 노션에 작성이 되어있어 읽으면서 열심히 하셨다고 생각이 들었어요! 😄 LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserController
Get /User : 유저 조회 (Feat#0 Create User)
Post /User : 유저 등록 (Feat#1 User Check)
QuizController
Get /Quiz : 퀴즈 요청 (Feat#3 Get Quiz)
Post /Quiz : 퀴즈 정답 제출 및 결과 응답 (Feat#4 Quiz response)