Add default image size for lazy loaded images #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's an issue left, some pictures trigger an error; hugo doesn't recognize them as resources and I can't figure out why. I asked for help on the hugo forum: https://discourse.gohugo.io/t/error-with-imageconfig-image-unknown-format/28985/7 |
NathanLovato
force-pushed
the
feature/lazy-image-size
branch
from
bcd81e6 to
7078eb6
Compare
NathanLovato
force-pushed
the
feature/lazy-image-size
branch
from
7078eb6 to
720eb70
Compare
NathanLovato
force-pushed
the
feature/lazy-image-size
branch
from
720eb70 to
20ccb2e
Compare
Here were the problems, and here’s the solution: 1. I had to mount the static folder to assets/ as suggested by @bep to be able to get all images as resources 2. You have to be careful about some types, like for example if you call safeURL on a path the returned object isn’t a string, so you can’t pass it to .Page.Resources.GetMatch 3. I had to use the .Page object to get resources. 4. Trying to evaluate width and height on an SVG resource fails. We use some SVGs in Markdown, as we sometimes use the format for lightweight game sprites and other graphic design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses hugo's resources to set the width and height attribute of lazy-loaded images so they don't pop on the screen, pushing the content down.
Part of #228