Feature/conexion list #7
Conversation
|
@esther-romero el build está roto, dale una mirada porfa |
|
Visit the preview URL for this PR (updated for commit 6430f3d): https://io-extended-cocha--pr7-feature-conexion-lis-x2p31oo4.web.app (expires Thu, 31 Aug 2023 19:57:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 51ece1238da40d06ce05072f712682fc540bb60b |
| @@ -65,8 +61,23 @@ import { CurrentUserState } from '../../core/states/current-user.state'; | |||
| text-align: center; | |||
| width: 100%; | |||
| } | |||
|
|
|||
| .buttons { | |||
There was a problem hiding this comment.
Aplica la metodología BEM para definir estilos. Esto debería llamarse: profile-details__actions o algo parecido
| @@ -10,17 +10,12 @@ import { AvatarImagePipe } from './avatar-image.pipe'; | |||
| import { AuthService } from '../../core/services/auth.service'; | |||
| import { CurrentUserState } from '../../core/states/current-user.state'; | |||
|
|
|||
| import { MatExpansionModule } from '@angular/material/expansion'; | |||
| import { ProfileFriendsComponent } from '../profile-friends/profile-friends.component'; | |||
There was a problem hiding this comment.
Los imports de angular ponlos en el bloque de imports externos, arriba
| QRCodeModule, | ||
| MatExpansionModule, | ||
| ProfileFriendsComponent, | ||
| ], |
There was a problem hiding this comment.
El haber movido todo este bloque abajo, hace que no sea evidente qué imports específicos fueron agregados. Recomendaría que lo vuelvas a colocar donde estaba.
| border-radius: 50%; | ||
| width: 35px; | ||
| height: 35px; | ||
| } |
There was a problem hiding this comment.
aplica BEM para nombrar tus estilos
| } | ||
| `, | ||
| ], | ||
| imports: [CommonModule, MatExpansionModule, MatIconModule, NgFor, NgIf], |
There was a problem hiding this comment.
Creo que no estás usando el CommonModule, eliminalo
| import { CurrentUserState } from 'src/app/core/states/current-user.state'; | ||
| import { MatExpansionModule } from '@angular/material/expansion'; | ||
| import { MatIconModule } from '@angular/material/icon'; | ||
| import { UserService } from 'src/app/core/services/user.service'; |
There was a problem hiding this comment.
Acomoda tus imports de acuerdo a como indiqué en el grupo, externos primero, locales después
|
@esther-romero las observaciones que te dejé para un próximo PR porfa, todas son observaciones menores |
No description provided.