Implementar página de perfil de cada participante #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0a95adc): https://io-extended-cocha--pr11-feature-user-profile-i46kofg7.web.app (expires Sat, 02 Sep 2023 02:31:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 51ece1238da40d06ce05072f712682fc540bb60b |
combimauri
reviewed
Aug 26, 2023
| @@ -41,10 +66,86 @@ import { ProfileFriendsComponent } from '../profile-friends/profile-friends.comp | |||
| [width]="256" | |||
| ></qrcode> | |||
| </div> | |||
| <div | |||
| class="profile-details__social-medial-container" | |||
| *ngIf="hasSocialMedia == true" | |||
combimauri
reviewed
Aug 26, 2023
| <h3 class="profile-details__social-medial-title">Redes Sociales</h3> | ||
| <ul class="profile-details__social-media-list"> | ||
| <li | ||
| *ngIf="user()?.facebookUsername !== ''" |
There was a problem hiding this comment.
user()?.facebookUsername
combimauri
reviewed
Aug 26, 2023
| @@ -66,25 +196,67 @@ import { ProfileFriendsComponent } from '../profile-friends/profile-friends.comp | |||
| justify-content: center; | |||
| margin-bottom: 0.5rem; | |||
| } | |||
|
|
|||
| .profile-details__social-medial-title { | |||
combimauri
reviewed
Aug 26, 2023
| this.user()?.twitterUsername !== '' || | ||
| this.user()?.instagramUsername !== '' || | ||
| this.user()?.githubUsername !== '' || | ||
| this.user()?.linkedinUsername !== ''; |
There was a problem hiding this comment.
hasSocialMedia =
this.user()?.facebookUsername ||
this.user()?.twitterUsername ||
this.user()?.instagramUsername ||
this.user()?.githubUsername ||
this.user()?.linkedinUsername;
combimauri
reviewed
Aug 26, 2023
|
|
||
| private auth = inject(AuthService); | ||
|
|
||
| private router = inject(Router); | ||
| constructor(private matIconRegistry: MatIconRegistry) { |
There was a problem hiding this comment.
No estamos manejando inyección de dependencias a través del constructor
combimauri
reviewed
Aug 26, 2023
|
|
||
| private auth = inject(AuthService); | ||
|
|
||
| private router = inject(Router); | ||
| constructor(private matIconRegistry: MatIconRegistry) { | ||
| // Add social media svg icons | ||
| this.matIconRegistry.addSvgIcon( |
There was a problem hiding this comment.
Ya que esto se usa solo dentro el constructor, realmente al inyectarlo no hay necesidad de darle un keyword de acceso, esto debería funcionar:
constructor(matIconRegistry: MatIconRegistry) {
matIconRegistry.addSvgIcon(...);
}
combimauri
reviewed
Aug 26, 2023
| import { MatFormFieldModule } from '@angular/material/form-field'; | ||
| import { MatInputModule } from '@angular/material/input'; | ||
| import { Router, RouterLink } from '@angular/router'; | ||
| import { CurrentUserState } from '../../core/states/current-user.state'; |
There was a problem hiding this comment.
Coloca este con los imports locales
combimauri
reviewed
Aug 26, 2023
| this.user()?.displayName || this.user()?.email, | ||
| [Validators.required], | ||
| ], | ||
| email: [this.user()?.email, [Validators.required, Validators.email]], |
There was a problem hiding this comment.
No deberían poder modificar su correo
combimauri
reviewed
Aug 26, 2023
| linkedinUsername: [this.user()?.linkedinUsername], | ||
| }); | ||
|
|
||
| editProfileSubject$ = new Subject<void>(); |
There was a problem hiding this comment.
esto debería ser privado
combimauri
reviewed
Aug 26, 2023
combimauri
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.