Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Development programs backend #12481

Merged
merged 13 commits into from
Jan 14, 2025
Prev Previous commit
Next Next commit
non-localized enum
petertgiles committed Jan 13, 2025
commit bac292e58c480f7698b65f1b2eb04fc91d749d38
9 changes: 0 additions & 9 deletions api/app/Enums/DevelopmentProgramParticipationStatus.php
Copy link
Contributor Author

@petertgiles petertgiles Jan 13, 2025 β€’

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've elected to not back-end localize this enum. On the applicant side, the UI uses the first person "I'm..." form of description and I don't see the descriptions on the admin side at all.

Original file line number Diff line number Diff line change
@@ -2,19 +2,10 @@

namespace App\Enums;

use App\Traits\HasLocalization;

enum DevelopmentProgramParticipationStatus
{
use HasLocalization;

case NOT_INTERESTED;
case INTERESTED;
case ENROLLED;
case COMPLETED;

public static function getLangFilename(): string
{
return 'development_program_participation_status';
}
}

Unchanged files with check annotations Beta

</Svg>
);
export default BackgroundGraphic;

Check warning on line 304 in apps/web/src/components/HeroDeprecated/BackgroundPattern.tsx

GitHub Actions / Lint

exported declaration 'default' not used within other modules
user: Pick<User, "firstName" | "lastName">,
) => <ChangeDateDialog selectedCandidateQuery={candidate} user={user} />;
export function viewTeamLinkCell(

Check warning on line 33 in apps/web/src/components/PoolStatusTable/cells.tsx

GitHub Actions / Lint

exported declaration 'viewTeamLinkCell' not used within other modules
url: Maybe<string> | undefined,
displayName: Maybe<LocalizedString> | undefined,
intl: IntlShape,
// eslint-disable-next-line deprecation/deprecation
const educationLevel: string | undefined = hasDiplomaToEducationLevel(
applicantFilter?.hasDiploma,

Check warning on line 92 in apps/web/src/components/SearchRequestFilters/SearchRequestFilters.tsx

GitHub Actions / Lint

'hasDiploma' is deprecated. hasDiploma to be replaced
intl,
);
);
}
export function viewTeamLinkCell(

Check warning on line 55 in apps/web/src/pages/Pools/IndexPoolPage/components/helpers.tsx

GitHub Actions / Lint

exported declaration 'viewTeamLinkCell' not used within other modules
url: Maybe<string> | undefined,
displayName: Maybe<LocalizedString> | undefined,
intl: IntlShape,
positionDuration: applicantFilter?.positionDuration
? applicantFilter.positionDuration
: null,
hasDiploma: applicantFilter?.hasDiploma

Check warning on line 288 in apps/web/src/pages/SearchRequests/RequestPage/components/RequestForm.tsx

GitHub Actions / Lint

'hasDiploma' is deprecated. hasDiploma to be replaced
? applicantFilter?.hasDiploma

Check warning on line 289 in apps/web/src/pages/SearchRequests/RequestPage/components/RequestForm.tsx

GitHub Actions / Lint

'hasDiploma' is deprecated. hasDiploma to be replaced
: false,
equity: applicantFilter?.equity,
languageAbility: applicantFilter?.languageAbility,
const operationalRequirementFilterCount =
filters?.operationalRequirements?.length ?? 0;
const educationSelection = filters?.hasDiploma;

Check warning on line 18 in apps/web/src/pages/SearchRequests/SearchPage/components/SearchFilterAdvice.tsx

GitHub Actions / Lint

'hasDiploma' is deprecated. hasDiploma to be replaced
const workingLanguage = filters?.languageAbility;
const employmentDuration = filters?.positionDuration;
const skillCount = filters?.skills?.length ?? 0;
...(data?.equity?.isVisibleMinority ? ["isVisibleMinority"] : []),
...(data?.equity?.isWoman ? ["isWoman"] : []),
],
educationRequirement: data.hasDiploma ? "has_diploma" : "no_diploma",

Check warning on line 118 in apps/web/src/pages/SearchRequests/SearchPage/utils.ts

GitHub Actions / Lint

'hasDiploma' is deprecated. hasDiploma to be replaced
skills: data.skills?.filter(notEmpty).map((s) => s.id) ?? [],
stream: stream?.id ?? "",
locationPreferences: data.locationPreferences?.filter(notEmpty) ?? [],
isIndigenous: applicantFilter.equity?.isIndigenous,
isVisibleMinority: applicantFilter.equity?.isVisibleMinority,
},
hasDiploma: applicantFilter?.hasDiploma,

Check warning on line 37 in apps/web/src/pages/SearchRequests/ViewSearchRequestPage/components/SearchRequestCandidatesTable.tsx

GitHub Actions / Lint

'hasDiploma' is deprecated. hasDiploma to be replaced
positionDuration: applicantFilter?.positionDuration,
languageAbility: applicantFilter.languageAbility?.value,
locationPreferences: applicantFilter?.locationPreferences
return false;
};
export const isTeamTeamable = (

Check warning on line 163 in apps/web/src/pages/Users/UpdateUserPage/components/helpers.tsx

GitHub Actions / Lint

exported declaration 'isTeamTeamable' not used within other modules
teamable: Teamable | undefined | null,
): teamable is TeamTeamable => {
if (teamable && teamable.__typename === "Team") {