[Fix] Getting started success toast always triggered #12374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€ Resolves #12327
π Introduction
Fixes and issue where the getting started form was always displaying the success message, even on failure.
π΅οΈ Details
Looks as though we were not rejecting the promise when there was an error on the main mutation, only in the mutation that occurs after. This lead to our error exchange showing an error toast and the success toast running regardless if there was an error.
π§ͺ Testing
Note
On success, you may still see error toast but this is going to be expected if you selected "verify email" submit action and do not have a GC Notify API key set. Technically this is correct since account creation is successful and the error is sending the verification email.
pnpm run dev:fresh
[email protected]
)